Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5603)

Unified Diff: chrome/browser/android/signin/signin_manager_android.cc

Issue 1256283002: GAIA ID migration for Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: simple version Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/signin/signin_manager_android.cc
diff --git a/chrome/browser/android/signin/signin_manager_android.cc b/chrome/browser/android/signin/signin_manager_android.cc
index d11e1adb0b409483ae392245111f4f2d5091b0ea..344396486fe9a67a119555258c368475fea41f96 100644
--- a/chrome/browser/android/signin/signin_manager_android.cc
+++ b/chrome/browser/android/signin/signin_manager_android.cc
@@ -103,8 +103,13 @@ void SigninManagerAndroid::CheckPolicyBeforeSignIn(JNIEnv* env,
username_ = base::android::ConvertJavaStringToUTF8(env, username);
policy::UserPolicySigninService* service =
policy::UserPolicySigninServiceFactory::GetForProfile(profile_);
+ std::string account_id = AccountTrackerServiceFactory::GetForProfile(profile_)
+ ->FindAccountInfoByEmail(username_)
+ .account_id;
+ if (account_id.empty())
+ account_id = username_;
Roger Tawa OOO till Jul 10th 2015/08/12 15:28:46 Under what cases would we want to use username as
gogerald1 2015/08/13 18:12:12 In this simple solution, services may need OAuth2T
service->RegisterForPolicy(
- base::android::ConvertJavaStringToUTF8(env, username),
+ username_, account_id,
base::Bind(&SigninManagerAndroid::OnPolicyRegisterDone,
weak_factory_.GetWeakPtr()));
#else

Powered by Google App Engine
This is Rietveld 408576698