Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 1256263006: Moved the cross-project parts of trace_event.h to trace_event_common.h (Closed)

Created:
5 years, 4 months ago by oystein (OOO til 10th of July)
Modified:
5 years, 4 months ago
Reviewers:
dsinclair, shatch
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved the cross-project parts of trace_event.h to trace_event_common.h This means other projects can copy it unmodified and keep their implementation details in trace_event.h trace_event_common.h also has some additional macros that were only found in the Blink copy of trace_event_.h previously. R=dsinclair BUG= Committed: https://crrev.com/e6e9521480c9c321f7e046da7a63ba9a0802f861 Cr-Commit-Position: refs/heads/master@{#341834}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1047 lines, -958 lines) Patch
M base/trace_event/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M base/trace_event/trace_event.h View 6 chunks +7 lines, -958 lines 0 comments Download
M base/trace_event/trace_event.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A base/trace_event/trace_event_common.h View 1 chunk +1038 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
oystein (OOO til 10th of July)
ptal!
5 years, 4 months ago (2015-07-31 21:57:30 UTC) #3
dsinclair
What were the blink only macros?
5 years, 4 months ago (2015-08-04 18:31:54 UTC) #5
oystein (OOO til 10th of July)
On 2015/08/04 18:31:54, dsinclair wrote: > What were the blink only macros? TRACE_EVENT_SET_NONCONST_SAMPLING_STATE, TRACE_EVENT_MARK_* and ...
5 years, 4 months ago (2015-08-04 18:40:47 UTC) #6
dsinclair
lgtm
5 years, 4 months ago (2015-08-04 20:08:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256263006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256263006/20001
5 years, 4 months ago (2015-08-04 20:13:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/88439)
5 years, 4 months ago (2015-08-04 22:16:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256263006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256263006/20001
5 years, 4 months ago (2015-08-04 22:22:09 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 4 months ago (2015-08-05 01:06:52 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 01:08:16 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6e9521480c9c321f7e046da7a63ba9a0802f861
Cr-Commit-Position: refs/heads/master@{#341834}

Powered by Google App Engine
This is Rietveld 408576698