src/heap/heap.h - Issue 1256203004: AdjustLiveBytes and friends takes a heap object pointer instead of an address.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.h

Issue 1256203004: AdjustLiveBytes and friends takes a heap object pointer instead of an address. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/heap.h

diff --git a/src/heap/heap.h b/src/heap/heap.h

index 15577ee02390be901caa9e71bd30cfca41fe2889..db5540fc93af89a26a30f3f7fd82bf6e6e6072ae 100644

--- a/src/heap/heap.h

+++ b/src/heap/heap.h

@@ -772,7 +772,7 @@ class Heap {

enum InvocationMode { SEQUENTIAL_TO_SWEEPER, CONCURRENT_TO_SWEEPER };

// Maintain consistency of live bytes during incremental marking.

- void AdjustLiveBytes(Address address, int by, InvocationMode mode);

+ void AdjustLiveBytes(HeapObject* object, int by, InvocationMode mode);

// Trim the given array from the left. Note that this relocates the object

// start and hence is only valid if there is only a single reference to it.

« no previous file with comments | « src/factory.cc ('k') | src/heap/heap.cc » ('j') | no next file with comments »