Fixed crashed when activating the context menu for toolbar buttons using Voiceover

chrome/browser/ui/cocoa/clickhold_button_cell_unittest.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/mac/scoped_nsobject.h"
 #import "chrome/browser/ui/cocoa/clickhold_button_cell.h"
 #import "chrome/browser/ui/cocoa/cocoa_test_helper.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 74 matching lines @@
   ASSERT_TRUE([cellTarget respondsToSelector:@selector(open)]);
   ASSERT_FALSE([cellTarget didOpen]);
 
   [cell setEnableClickHold:NO];
 
   NSArray* actionNames = [cell accessibilityActionNames];
   EXPECT_FALSE([actionNames containsObject:NSAccessibilityShowMenuAction]);
 
   [cell setEnableClickHold:YES];
 
+  // There is no action set.
+  actionNames = [cell accessibilityActionNames];
+  EXPECT_FALSE([actionNames containsObject:NSAccessibilityShowMenuAction]);
+
+  // clickHoldAction should be independent from accessibilityShowMenuAction
+  // since different operations, e.g. releasing vs. not releasing a mouse
+  // button, may need to be performed for each occasion.
+  [cell setClickHoldAction:@selector(open)];
+  [cell setClickHoldTarget:cellTarget];
+
+  actionNames = [cell accessibilityActionNames];
+  EXPECT_FALSE([actionNames containsObject:NSAccessibilityShowMenuAction]);
+  EXPECT_FALSE([cellTarget didOpen]);
+
+  // Even when accessibilityShowMenuAction is set, no action should be available
+  // if neither enableClickHold nor enableRightClickHold are true.
+  [cell setEnableClickHold:NO];
+  [cell setAccessibilityShowMenuAction:@selector(open)];
+  [cell setAccessibilityShowMenuTarget:cellTarget];
+
   actionNames = [cell accessibilityActionNames];
   EXPECT_FALSE([actionNames containsObject:NSAccessibilityShowMenuAction]);
 
-  [cell setClickHoldAction:@selector(open)];
-  [cell setClickHoldTarget:cellTarget];
+  // Now the action should be available.
+  [cell setEnableClickHold:YES];
+
+  actionNames = [cell accessibilityActionNames];
+  EXPECT_TRUE([actionNames containsObject:NSAccessibilityShowMenuAction]);
+
+  [cell setEnableClickHold:NO];
+[cell setEnableRightClick:YES];

[Avi (use Gerrit), 2015/08/01 03:58:51]

indent 2

 
   actionNames = [cell accessibilityActionNames];
   EXPECT_TRUE([actionNames containsObject:NSAccessibilityShowMenuAction]);
 
   [cell accessibilityPerformAction:NSAccessibilityShowMenuAction];
   EXPECT_TRUE([cellTarget didOpen]);
 }
 
 }  // namespace