Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1256183002: 'break' statement after 'return' is not required. (Closed)

Created:
5 years, 4 months ago by Deepak
Modified:
5 years, 4 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

'break' statement after 'return' is not required. There is no use of 'break' after 'return' call as control will return immediately after return call. BUG=514151 Committed: https://crrev.com/6b5a579fc38aec5d9b50056f54ce0011fc388550 Cr-Commit-Position: refs/heads/master@{#340452}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M base/prefs/json_pref_store.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Deepak
PTAL this small clean up patch. Thanks
5 years, 4 months ago (2015-07-27 09:30:12 UTC) #2
Bernhard Bauer
lgtm
5 years, 4 months ago (2015-07-27 10:04:33 UTC) #3
Deepak
On 2015/07/27 10:04:33, Bernhard Bauer wrote: > lgtm Thanks.
5 years, 4 months ago (2015-07-27 10:05:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256183002/1
5 years, 4 months ago (2015-07-27 10:05:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-27 11:40:28 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 11:41:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b5a579fc38aec5d9b50056f54ce0011fc388550
Cr-Commit-Position: refs/heads/master@{#340452}

Powered by Google App Engine
This is Rietveld 408576698