Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1256173003: Make The task manager browser tests for the print preview work under --site-per-process (Closed)

Created:
5 years, 4 months ago by afakhry
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make The task manager browser tests for the print preview work under --site-per-process The newly added test fails under --site-per-process. The reason is we used to navigate to the NTP which used to create an extra task (SubframeTask) in the task manager. Failure link is here: http://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Linux/builds/3418 TBR=nick@chromium.org, thestig@chromium.org BUG=470995 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/46d4b6d4fb946f47137458e82390a773e1b5cc32 Cr-Commit-Position: refs/heads/master@{#340805}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/printing/print_preview_dialog_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256173003/1
5 years, 4 months ago (2015-07-28 22:04:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256173003/1
5 years, 4 months ago (2015-07-28 22:27:14 UTC) #5
ncarter (slow)
lgtm
5 years, 4 months ago (2015-07-28 22:28:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-28 23:34:50 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 23:35:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46d4b6d4fb946f47137458e82390a773e1b5cc32
Cr-Commit-Position: refs/heads/master@{#340805}

Powered by Google App Engine
This is Rietveld 408576698