Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1256163003: X87: [turbofan] Fix kArchTailCallCodeObject on ia32/x64. (Closed)

Created:
5 years, 4 months ago by chunyang.dai
Modified:
5 years, 4 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Fix kArchTailCallCodeObject on ia32/x64. port ec9bc7947399e29429c3bdeaff070db2a4cc92f4 (r29949). original commit message: Previously these instructions tried to jump to the value at the code entry's location, rather than jumping to this location. Also adds a test. BUG= Committed: https://crrev.com/872206f4c2df72ebe0467e848224e53685abd704 Cr-Commit-Position: refs/heads/master@{#29964}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 4 months ago (2015-08-03 02:19:36 UTC) #2
Weiliang
lgtm
5 years, 4 months ago (2015-08-03 02:44:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256163003/1
5 years, 4 months ago (2015-08-03 02:44:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-03 03:10:15 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 03:10:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/872206f4c2df72ebe0467e848224e53685abd704
Cr-Commit-Position: refs/heads/master@{#29964}

Powered by Google App Engine
This is Rietveld 408576698