Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1256133004: Remove WEBKIT_VERSION_MIN_REQUIRED and config.h. (Closed)

Created:
5 years, 4 months ago by bungeman-skia
Modified:
5 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove WEBKIT_VERSION_MIN_REQUIRED and config.h. WebKit style guide (https://www.webkit.org/coding/coding-style.html) explicitly states: > All implementation files must #include "config.h" first. > Header files should never include "config.h". Also, it isn't currently being used. TBR=reed@google.com This just removes unused bits. Committed: https://skia.googlesource.com/skia/+/a15cd9cb7fad31b93cd44541993b69bd5d006582

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M include/core/SkPreConfig.h View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256133004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256133004/1
5 years, 4 months ago (2015-07-29 21:37:44 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 21:46:16 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a15cd9cb7fad31b93cd44541993b69bd5d006582

Powered by Google App Engine
This is Rietveld 408576698