Source/modules/serviceworkers/ExtendableEvent.idl - Issue 1256133002: Service Worker: Correct Web IDL of ExtendableEvent.waitUntil method.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/serviceworkers/ExtendableEvent.idl

Issue 1256133002: Service Worker: Correct Web IDL of ExtendableEvent.waitUntil method. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address comment: add/delete headers. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/modules/serviceworkers/ExtendableEvent.cpp ('k') | Source/modules/serviceworkers/WaitUntilObserver.h » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2014 Google Inc. All rights reserved.	2 * Copyright (C) 2014 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 16 matching lines...) Expand all Loading...
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE	27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE

28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.	28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

29 */	29 */

30	30

31 // https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#extendable-e vent-interface	31 // https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#extendable-e vent-interface

32 [	32 [

33 Constructor(DOMString type, optional ExtendableEventInit eventInitDict),	33 Constructor(DOMString type, optional ExtendableEventInit eventInitDict),

34 Exposed=ServiceWorker,	34 Exposed=ServiceWorker,

35 TypeChecking=Interface,	35 TypeChecking=Interface,

36 ] interface ExtendableEvent : Event {	36 ] interface ExtendableEvent : Event {

37 [CallWith=ScriptState, RaisesException] void waitUntil(any value);	37 [CallWith=ScriptState, RaisesException] void waitUntil(Promise<any> f);
	falken 2015/07/29 08:14:55 what does f stand for? I see it's in the spec as w what does f stand for? I see it's in the spec as well. Should it be something more understandable or is this a common convention? jungkees 2015/07/29 08:34:18 Ah, I didn't see this comment before seeing an lgt Show quoted text On 2015/07/29 08:14:55, falken wrote: > what does f stand for? I see it's in the spec as well. Should it be something > more understandable or is this a common convention? Ah, I didn't see this comment before seeing an lgtm from nhiroki and committing it. I also had a same question. I don't think it is a convention, but couldn't come up with a better generic name that represents just a functional entity that can be either a promise or a value there. I guess Jake or Alex initially named it so. I'm willing to change it if we have a better one for it.
38 };	38 };

OLD	NEW