Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1256113004: Server options file gets a dot. (Closed)

Created:
5 years, 4 months ago by pquitslund
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Server options file gets a dot.

Patch Set 1 #

Patch Set 2 : Extension fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M pkg/analysis_server/lib/src/server_options.dart View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
pquitslund
Seth's idea and I don't object. Any reason for this to NOT be hidden?
5 years, 4 months ago (2015-07-30 21:21:24 UTC) #2
sethladd
We can bike shed on the name later, but +1 for moving to a dot ...
5 years, 4 months ago (2015-07-30 21:26:00 UTC) #3
scheglov
Same here, the name may be different, but adding dot is a step in the ...
5 years, 4 months ago (2015-07-30 21:28:35 UTC) #4
Brian Wilkerson
LGTM The only consideration I know of is how dot files are handled by some ...
5 years, 4 months ago (2015-07-30 21:31:26 UTC) #5
pquitslund
On 2015/07/30 21:26:00, sethladd wrote: > We can bike shed on the name later, but ...
5 years, 4 months ago (2015-07-30 22:56:38 UTC) #6
sethladd
5 years, 4 months ago (2015-07-30 23:08:20 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698