Issue 12561004: Merge 144608 "Web Inspector: touchmove not emulated inside iframe"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12561004: Merge 144608 "Web Inspector: touchmove not emulated inside iframe" (Closed)

Created:
7 years, 9 months ago by apavlov

Modified:
7 years, 9 months ago

Reviewers:
apavlov

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/

Visibility:
Public.

More Reviews

Description

Merge 144608 "Web Inspector: touchmove not emulated inside iframe" > Web Inspector: touchmove not emulated inside iframe > https://bugs.webkit.org/show_bug.cgi?id=111292 > > Reviewed by Vsevolod Vlasov. > > Source/WebCore: > > Move fake touch event dispatching from mouseMoved() into handleMouseMoveEvent() > and bail out earlier from dispatchSyntheticTouchEventIfEnabled() when the event > should be dispatched on a subframe. > > * page/EventHandler.cpp: > (WebCore::EventHandler::mouseMoved): > (WebCore::EventHandler::handleMouseMoveEvent): > (WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled): > > LayoutTests: > > * fast/events/touch/emulated-touch-iframe.html: > * fast/events/touch/resources/emulated-touch-iframe2.html: TBR=apavlov@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145699

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -12 lines)			Patch
M	LayoutTests/fast/events/touch/emulated-touch-iframe.html	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/events/touch/resources/emulated-touch-iframe2.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/WebCore/page/EventHandler.cpp	View	3 chunks	+10 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r145699.

Expand Messages | Collapse Messages