Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 12561003: MIPS: ES6 symbols: Allow symbols as property names (Closed)

Created:
7 years, 9 months ago by palfia
Modified:
7 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: ES6 symbols: Allow symbols as property names Port r13811 (0e64f280) Original commit message: Since symbols and strings share a common representation, most of this change is about consistently replacing 'String' with 'Name' in all places where property names are expected. In particular, no new logic at all is necessary for maps, property dictionaries, or transitions. :) The only places where an actual case distinction is needed have to do with generated type checks, and with conversions of names to strings (especially in logger and profiler). Left in some TODOs wrt to the API: interceptors and native getters don't accept symbols as property names yet, because that would require extending the external v8.h. (Baseline CL: https://codereview.chromium.org/12296026/) BUG= Committed: https://code.google.com/p/v8/source/detail?r=13874

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -165 lines) Patch
M src/mips/code-stubs-mips.h View 3 chunks +8 lines, -8 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 11 chunks +51 lines, -46 lines 0 comments Download
M src/mips/ic-mips.cc View 17 chunks +64 lines, -59 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 2 chunks +23 lines, -0 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 32 chunks +54 lines, -52 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
This CL depends on: https://codereview.chromium.org/12560004
7 years, 9 months ago (2013-03-07 02:14:33 UTC) #1
rossberg
lgtm
7 years, 9 months ago (2013-03-07 12:48:08 UTC) #2
palfia
7 years, 9 months ago (2013-03-08 00:49:37 UTC) #3
Message was sent while issue was closed.
Committed manually as r13874 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698