Source/modules/webaudio/OscillatorNode.h - Issue 1256053006: Protect AudioScheduledSoureNode::m_startTime and m_endTime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/OscillatorNode.h

Issue 1256053006: Protect AudioScheduledSoureNode::m_startTime and m_endTime. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use tryLock instead of atomic access Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/webaudio/AudioScheduledSourceNode.cpp ('k') | Source/modules/webaudio/OscillatorNode.cpp » ('j') | Source/modules/webaudio/OscillatorNode.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webaudio/OscillatorNode.h

diff --git a/Source/modules/webaudio/OscillatorNode.h b/Source/modules/webaudio/OscillatorNode.h

index 66a0497daffb30cbf8b6f688fba217adc2db3daf..d80f27dc84e8bbc7409c4146d7e1d00cbe016600 100644

--- a/Source/modules/webaudio/OscillatorNode.h

+++ b/Source/modules/webaudio/OscillatorNode.h

@@ -88,9 +88,6 @@ private:

// Since it's floating-point, it has sub-sample accuracy.

double m_virtualReadIndex;

- // This synchronizes process().

- mutable Mutex m_processLock;

// Stores sample-accurate values calculated according to frequency and detune.

AudioFloatArray m_phaseIncrements;

AudioFloatArray m_detuneValues;