Source/core/frame/FrameView.cpp - Issue 1256043007: Recompute slow scroll regions after overflow recalc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/FrameView.cpp

Issue 1256043007: Recompute slow scroll regions after overflow recalc (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: replace iframe with div Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/scrollingcoordinator/non-fast-scrollable-transform-changed-expected.txt ('k') | Source/core/page/scrolling/ScrollingCoordinator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/FrameView.cpp

diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp

index c9c429ac81677e8f703528ccb03a89e71f526610..2114e303526b6d5fd6fc80500380fb502dfe1edd 100644

--- a/Source/core/frame/FrameView.cpp

+++ b/Source/core/frame/FrameView.cpp

@@ -642,6 +642,11 @@ void FrameView::recalcOverflowAfterStyleChange()

layoutView->recalcOverflowAfterStyleChange();

+ // Changing overflow should notify scrolling coordinator to ensures that it

+ // updates non-fast scroll rects even if there is no layout.

+ if (ScrollingCoordinator* scrollingCoordinator = this->scrollingCoordinator())

+ scrollingCoordinator->notifyOverflowUpdated();

IntRect documentRect = layoutView->documentRect();

if (scrollOrigin() == -documentRect.location() && contentsSize() == documentRect.size())

return;