Issue 1256033004: Revert of Re-enable ChannelMojo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1256033004: Revert of Re-enable ChannelMojo (Closed)

Created:
5 years, 4 months ago by Ken Rockot(use gerrit already)

Modified:
5 years, 4 months ago

Reviewers:
jam

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Re-enable ChannelMojo (patchset #1 id:80001 of https://codereview.chromium.org/1256473002/) Reason for revert: Maybe breaking layout tests...somehow Original issue's description: > Re-enable ChannelMojo > > I'm pretty sure the previous perf regression was a false > signal. Haven't reproed with other benchmarks and in > retrospect turning ChannelMojo off never fixed the > regression in question anyway. > > BUG=500019 > > Committed: https://crrev.com/ccfe630130d0b4768338a88361c98cc8fc35f758 > Cr-Commit-Position: refs/heads/master@{#340975} TBR=jam@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=500019 Committed: https://crrev.com/db1f070326b69d6402f9d21c82bbdeabdbf1d20d Cr-Commit-Position: refs/heads/master@{#341001}

Patch Set 1 #

Created: 5 years, 4 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	ipc/mojo/ipc_channel_mojo.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ken Rockot(use gerrit already)

Created Revert of Re-enable ChannelMojo

5 years, 4 months ago (2015-07-29 22:13:12 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256033004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256033004/1

5 years, 4 months ago (2015-07-29 22:14:57 UTC) #2

commit-bot: I haz the power

5 years, 4 months ago (2015-07-29 22:17:36 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/db1f070326b69d6402f9d21c82bbdeabdbf1d20d
Cr-Commit-Position: refs/heads/master@{#341001}

Expand Messages | Collapse Messages