Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1256023004: Add EME test to attempt multiple calls to setMediaKeys() (Closed)

Created:
5 years, 5 months ago by jrummell
Modified:
5 years, 3 months ago
CC:
blink-reviews, mlamouri+watch-blink_chromium.org, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add EME test to attempt multiple calls to setMediaKeys() As setting mediaKeys is currently only allowed once, verify that multiple calls in parallel don't crash. TEST=new tests passes Committed: https://crrev.com/644a2fccbf38a4ef4e6853083608d67fa86998a3 git-svn-id: svn://svn.chromium.org/blink/trunk@199539 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Total comments: 2

Patch Set 2 : first required #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -0 lines) Patch
A LayoutTests/media/encrypted-media/encrypted-media-set-mediakeys-at-same-time.html View 1 1 chunk +104 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jrummell
PTAL.
5 years, 5 months ago (2015-07-24 20:41:02 UTC) #2
xhwang
https://codereview.chromium.org/1256023004/diff/1/LayoutTests/media/encrypted-media/encrypted-media-set-mediakeys-at-same-time.html File LayoutTests/media/encrypted-media/encrypted-media-set-mediakeys-at-same-time.html (right): https://codereview.chromium.org/1256023004/diff/1/LayoutTests/media/encrypted-media/encrypted-media-set-mediakeys-at-same-time.html#newcode94 LayoutTests/media/encrypted-media/encrypted-media-set-mediakeys-at-same-time.html:94: // succeeded. can we be a bit more strict ...
5 years, 5 months ago (2015-07-24 20:56:36 UTC) #3
jrummell
Updated to make sure the first call succeeds. https://codereview.chromium.org/1256023004/diff/1/LayoutTests/media/encrypted-media/encrypted-media-set-mediakeys-at-same-time.html File LayoutTests/media/encrypted-media/encrypted-media-set-mediakeys-at-same-time.html (right): https://codereview.chromium.org/1256023004/diff/1/LayoutTests/media/encrypted-media/encrypted-media-set-mediakeys-at-same-time.html#newcode94 LayoutTests/media/encrypted-media/encrypted-media-set-mediakeys-at-same-time.html:94: // ...
5 years, 5 months ago (2015-07-24 23:11:01 UTC) #4
xhwang
lgtm
5 years, 5 months ago (2015-07-24 23:14:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256023004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256023004/20001
5 years, 4 months ago (2015-07-27 22:03:56 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=199539
5 years, 4 months ago (2015-07-27 23:31:39 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:49:27 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/644a2fccbf38a4ef4e6853083608d67fa86998a3

Powered by Google App Engine
This is Rietveld 408576698