Issue 12560005: Merge 139854

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12560005: Merge 139854 (Closed)

Created:
7 years, 9 months ago by haraken

Modified:
7 years, 9 months ago

Reviewers:
haraken

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/

Visibility:
Public.

More Reviews

Description

Merge 139854 > [V8] Make an Isolate parameter mandatory in SerializedScriptValue::deserialize() > https://bugs.webkit.org/show_bug.cgi?id=106916 > > Reviewed by Adam Barth. > > This is one of steps to remove optional Isolate parameters. > > No tests. No change in behavior. > > * bindings/v8/SerializedScriptValue.cpp: > (WebCore::SerializedScriptValue::deserialize): > (WebCore): > (WebCore::SerializedScriptValue::deserializeForInspector): > * bindings/v8/SerializedScriptValue.h: > (SerializedScriptValue): > * bindings/v8/custom/V8HistoryCustom.cpp: > (WebCore::V8History::stateAccessorGetter): > * bindings/v8/custom/V8MessageEventCustom.cpp: > (WebCore::V8MessageEvent::dataAccessorGetter): > * bindings/v8/custom/V8PopStateEventCustom.cpp: > (WebCore::V8PopStateEvent::stateAccessorGetter): > TBR=haraken@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145019

Patch Set 1 #

Created: 7 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -9 lines)			Patch
M	Source/WebCore/bindings/v8/ScriptState.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	Source/WebCore/bindings/v8/SerializedScriptValue.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	Source/WebCore/bindings/v8/SerializedScriptValue.cpp	View	2 chunks	+8 lines, -3 lines	0 comments	Download
M	Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r145019.

Expand Messages | Collapse Messages