Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 12560003: Add support for Var arrays to ArrayWriter. (Closed)

Created:
7 years, 9 months ago by bbudge
Modified:
7 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add support for Var arrays to ArrayWriter. BUG=79375 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186832

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -3 lines) Patch
M ppapi/shared_impl/array_writer.h View 1 2 chunks +16 lines, -3 lines 0 comments Download
M ppapi/shared_impl/array_writer.cc View 2 chunks +50 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bbudge
7 years, 9 months ago (2013-03-07 01:53:12 UTC) #1
dmichael (off chromium)
lgtm https://codereview.chromium.org/12560003/diff/1/ppapi/shared_impl/array_writer.h File ppapi/shared_impl/array_writer.h (right): https://codereview.chromium.org/12560003/diff/1/ppapi/shared_impl/array_writer.h#newcode109 ppapi/shared_impl/array_writer.h:109: // one instantiation and is sufficient for now. ...
7 years, 9 months ago (2013-03-07 16:19:23 UTC) #2
bbudge
https://codereview.chromium.org/12560003/diff/1/ppapi/shared_impl/array_writer.h File ppapi/shared_impl/array_writer.h (right): https://codereview.chromium.org/12560003/diff/1/ppapi/shared_impl/array_writer.h#newcode109 ppapi/shared_impl/array_writer.h:109: // one instantiation and is sufficient for now. On ...
7 years, 9 months ago (2013-03-07 17:49:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/12560003/15001
7 years, 9 months ago (2013-03-07 17:50:31 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-08 00:42:21 UTC) #5
Message was sent while issue was closed.
Change committed as 186832

Powered by Google App Engine
This is Rietveld 408576698