Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 1255953002: MIPS: [stubs] Further optimize Load/StoreGlobalViaContext stubs. (Closed)

Created:
5 years, 5 months ago by balazs.kilvady
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [stubs] Further optimize Load/StoreGlobalViaContext stubs. a) Don't use separate read/write slots for context globals, but share the same slot, which reduces the number of initial misses, and also saves some memory for large scripts. b) No need to pass the name explicitly to the stubs; the runtime can extract the name from the ScopeInfo (the extension of the ScriptContext) on-demand easily without any performance impact. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -74 lines) Patch
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 6 chunks +7 lines, -12 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/mips/lithium-mips.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 6 chunks +7 lines, -12 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/mips64/lithium-mips64.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
paul.l...
l-g-t-m for inclusion in https://codereview.chromium.org/1250413002/
5 years, 5 months ago (2015-07-26 18:55:31 UTC) #2
Benedikt Meurer
5 years, 4 months ago (2015-07-27 10:45:53 UTC) #3
Thanks a lot.

Powered by Google App Engine
This is Rietveld 408576698