Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1255943006: Allow setting of GrBatchFontCache atlas sizes (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@debugatlas2
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Allow setting of GrBatchFontCache atlas sizes BUG=skia: Committed: https://skia.googlesource.com/skia/+/da04e0e80a0113e1d838f7406cd8a8d545b8c02b

Patch Set 1 #

Patch Set 2 : remove GrFontAtlasSizes #

Patch Set 3 : rebase #

Patch Set 4 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -52 lines) Patch
M gyp/gpu.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M include/gpu/GrContext.h View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M src/gpu/GrBatchAtlas.h View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M src/gpu/GrBatchFontCache.h View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M src/gpu/GrBatchFontCache.cpp View 1 2 3 4 chunks +33 lines, -10 lines 0 comments Download
D src/gpu/GrFontAtlasSizes.h View 1 1 chunk +0 lines, -39 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
joshualitt
ptal.
5 years, 4 months ago (2015-08-04 19:50:17 UTC) #2
bsalomon
lgtm
5 years, 4 months ago (2015-08-04 20:07:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255943006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255943006/20001
5 years, 4 months ago (2015-08-08 18:24:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/2586)
5 years, 4 months ago (2015-08-08 18:27:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255943006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255943006/40001
5 years, 4 months ago (2015-08-10 13:19:24 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/2539)
5 years, 4 months ago (2015-08-10 13:22:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255943006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255943006/60001
5 years, 4 months ago (2015-08-19 15:06:40 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 15:16:46 UTC) #17
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/da04e0e80a0113e1d838f7406cd8a8d545b8c02b

Powered by Google App Engine
This is Rietveld 408576698