Source/modules/serviceworkers/FetchEvent.cpp - Issue 1255933004: Service Worker: Correct Web IDL of FetchEvent.respondWith method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/FetchEvent.cpp

Issue 1255933004: Service Worker: Correct Web IDL of FetchEvent.respondWith method. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rename IDL argument and method params. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/serviceworker/resources/fetch-event-respond-with-argument-iframe.html ('K') | « Source/modules/serviceworkers/FetchEvent.h ('k') | Source/modules/serviceworkers/FetchEvent.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/FetchEvent.cpp

diff --git a/Source/modules/serviceworkers/FetchEvent.cpp b/Source/modules/serviceworkers/FetchEvent.cpp

index 2c1db23b870a63a164152f5c93bfa92ce629bc36..2eaabaf03696a8eb3cb7f12247175f9963ad0312 100644

--- a/Source/modules/serviceworkers/FetchEvent.cpp

+++ b/Source/modules/serviceworkers/FetchEvent.cpp

@@ -36,10 +36,10 @@ bool FetchEvent::isReload() const

return m_isReload;

}

-void FetchEvent::respondWith(ScriptState* scriptState, const ScriptValue& value, ExceptionState& exceptionState)

+void FetchEvent::respondWith(ScriptState* scriptState, ScriptPromise& responsePromise, ExceptionState& exceptionState)

{

stopImmediatePropagation();

- m_observer->respondWith(scriptState, value, exceptionState);

+ m_observer->respondWith(scriptState, responsePromise, exceptionState);

}

const AtomicString& FetchEvent::interfaceName() const