Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Unified Diff: LayoutTests/http/tests/serviceworker/resources/fetch-event-respond-with-argument-iframe.html

Issue 1255933004: Service Worker: Correct Web IDL of FetchEvent.respondWith method. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rename IDL argument and method params. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/serviceworker/resources/fetch-event-respond-with-argument-iframe.html
diff --git a/LayoutTests/http/tests/serviceworker/resources/fetch-event-network-error-controllee-iframe.html b/LayoutTests/http/tests/serviceworker/resources/fetch-event-respond-with-argument-iframe.html
similarity index 78%
copy from LayoutTests/http/tests/serviceworker/resources/fetch-event-network-error-controllee-iframe.html
copy to LayoutTests/http/tests/serviceworker/resources/fetch-event-respond-with-argument-iframe.html
index a4c9307e745e2625b9048ab105ee8855262471ba..33b47e78a349dfda70f9dc9a230a34152305640c 100644
--- a/LayoutTests/http/tests/serviceworker/resources/fetch-event-network-error-controllee-iframe.html
+++ b/LayoutTests/http/tests/serviceworker/resources/fetch-event-respond-with-argument-iframe.html
@@ -34,13 +34,9 @@ function make_test(testcase) {
function run_tests() {
var tests = [
- { name: 'prevent-default-and-respond-with', expect_load: true },
- { name: 'prevent-default', expect_load: false },
- { name: 'reject', expect_load: false },
- { name: 'unused-body', expect_load: true },
- { name: 'used-body', expect_load: false },
- { name: 'unused-fetched-body', expect_load: true },
- { name: 'used-fetched-body', expect_load: false }
+ { name: 'response-object', expect_load: true },
+ { name: 'response-promise-object', expect_load: true },
+ { name: 'other-value', expect_load: false },
falken 2015/07/27 00:44:41 'object' or 'object-instance' seems more clear tha
jungkees 2015/07/27 01:21:32 IMO, any single case which is neither a Response n
].map(make_test);
Promise.all(tests)

Powered by Google App Engine
This is Rietveld 408576698