LayoutTests/http/tests/serviceworker/fetch-event-respond-with-argument.html - Issue 1255933004: Service Worker: Correct Web IDL of FetchEvent.respondWith method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/serviceworker/fetch-event-respond-with-argument.html

Issue 1255933004: Service Worker: Correct Web IDL of FetchEvent.respondWith method. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rename IDL argument and method params. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | LayoutTests/http/tests/serviceworker/resources/fetch-event-respond-with-argument-iframe.html » ('j') | LayoutTests/http/tests/serviceworker/resources/fetch-event-respond-with-argument-iframe.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/serviceworker/fetch-event-respond-with-argument.html

diff --git a/LayoutTests/http/tests/serviceworker/fetch-event-network-error.html b/LayoutTests/http/tests/serviceworker/fetch-event-respond-with-argument.html

similarity index 73%

copy from LayoutTests/http/tests/serviceworker/fetch-event-network-error.html

copy to LayoutTests/http/tests/serviceworker/fetch-event-respond-with-argument.html

index 567ffc14dfa218dc9807f8a283f42e326594e4b8..ba69cc76b5e5282efff70e71971e458f75b7b4a4 100644

--- a/LayoutTests/http/tests/serviceworker/fetch-event-network-error.html

+++ b/LayoutTests/http/tests/serviceworker/fetch-event-respond-with-argument.html

@@ -1,5 +1,5 @@

<!DOCTYPE html>

-<title>Service Worker: Fetch event network error</title>

+<title>Service Worker: FetchEvent.respondWith() argument type test.</title>

@@ -17,8 +17,8 @@ function notify_test_done(result) {

}

promise_test(function(t) {

- var scope = 'resources/fetch-event-network-error-controllee-iframe.html';

- var script = 'resources/fetch-event-network-error-worker.js';

+ var scope = 'resources/fetch-event-respond-with-argument-iframe.html';

+ var script = 'resources/fetch-event-respond-with-argument-worker.js';

var frame;

return service_worker_unregister_and_register(t, script, scope)

@@ -37,6 +37,6 @@ promise_test(function(t) {

assert_equals(result, 'PASS');

return service_worker_unregister_and_done(t, scope);

});

- }, 'Rejecting the fetch event or using preventDefault() causes a network ' +

- 'error');

+ }, 'respondWith() takes either a Response or a promise that resolves ' +

+ 'with a Response. Other values should raise a network error.');

</script>