Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: Source/modules/serviceworkers/RespondWithObserver.h

Issue 1255933004: Service Worker: Correct Web IDL of FetchEvent.respondWith method. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Update the title and the description of the layout test. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/serviceworkers/FetchEvent.idl ('k') | Source/modules/serviceworkers/RespondWithObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/serviceworkers/RespondWithObserver.h
diff --git a/Source/modules/serviceworkers/RespondWithObserver.h b/Source/modules/serviceworkers/RespondWithObserver.h
index 74c0766ec91dbcb528ccb78f4ea1e90f8ce0241e..f4de384b92b2552b53e31f4d96104cb892a00fd2 100644
--- a/Source/modules/serviceworkers/RespondWithObserver.h
+++ b/Source/modules/serviceworkers/RespondWithObserver.h
@@ -5,6 +5,7 @@
#ifndef RespondWithObserver_h
#define RespondWithObserver_h
+#include "bindings/core/v8/ScriptPromise.h"
zino 2015/07/25 21:29:21 nit: I think it is better to use a class forward d
jungkees 2015/07/26 08:37:40 That's right. I addressed it. Thanks for review.
#include "core/dom/ContextLifecycleObserver.h"
#include "modules/ModulesExport.h"
#include "platform/heap/Handle.h"
@@ -31,7 +32,7 @@ public:
// Observes the promise and delays calling didHandleFetchEvent() until the
// given promise is resolved or rejected.
- void respondWith(ScriptState*, const ScriptValue&, ExceptionState&);
+ void respondWith(ScriptState*, ScriptPromise&, ExceptionState&);
void responseWasRejected(WebServiceWorkerResponseError);
void responseWasFulfilled(const ScriptValue&);
« no previous file with comments | « Source/modules/serviceworkers/FetchEvent.idl ('k') | Source/modules/serviceworkers/RespondWithObserver.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698