Issue 125593006: <webview>: guest pages embedded in WebUI should appear in chrome://inspect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125593006: <webview>: guest pages embedded in WebUI should appear in chrome://inspect (Closed)

Created:
6 years, 11 months ago by Fady Samuel

Modified:
6 years, 11 months ago

Reviewers:
Vladislav Kaznacheev

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

<webview>: guest pages embedded in WebUI should appear in chrome://inspect BUG=332410 TBR=kaznacheev@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243966

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/resources/inspect/inspect.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Fady Samuel

This change is fairly trivial. I'm TBR'ing due to the significant timezone differences.

6 years, 11 months ago (2014-01-09 16:43:54 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/125593006/1

6 years, 11 months ago (2014-01-09 16:44:17 UTC) #4

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=244166

6 years, 11 months ago (2014-01-09 19:07:04 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/125593006/1

6 years, 11 months ago (2014-01-09 19:08:53 UTC) #6

Message was sent while issue was closed.

Change committed as 243966

Expand Messages | Collapse Messages