Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 125593005: Rename EventContext to NodeEventContext. (Closed)

Created:
6 years, 11 months ago by hayato
Modified:
6 years, 11 months ago
Reviewers:
dglazkov
CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Rename EventContext to NodeEventContext. This is a follow-up patch for https://codereview.chromium.org/108723007/. BUG=329445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164665

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M Source/core/dom/Node.h View 1 2 chunks +1 line, -1 line 0 comments Download
M Source/core/events/EventContext.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/events/EventContext.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/EventDispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/EventDispatcher.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/events/EventPath.h View 1 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/events/EventPath.cpp View 1 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/events/WindowEventContext.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/events/WindowEventContext.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hayato
This patch need to be rebased after https://codereview.chromium.org/125033002/ is landed.
6 years, 11 months ago (2014-01-07 06:03:55 UTC) #1
hayato
6 years, 11 months ago (2014-01-07 06:04:22 UTC) #2
hayato
I will split each EventContext (NodeEventContext, TreeScopeEventContext, TouchEventContext) into its own file after this patch.
6 years, 11 months ago (2014-01-07 06:07:42 UTC) #3
dglazkov
rslgtm
6 years, 11 months ago (2014-01-07 21:36:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/125593005/80001
6 years, 11 months ago (2014-01-08 06:07:40 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 09:48:03 UTC) #6
Message was sent while issue was closed.
Change committed as 164665

Powered by Google App Engine
This is Rietveld 408576698