Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1255883006: CC Animation: Fix pauseAnimation so it doesn't reset blink negative delays (Closed)

Created:
5 years, 4 months ago by loyso (OOO)
Modified:
5 years, 4 months ago
Reviewers:
Ian Vollick, ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@disable
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Fix pauseAnimation so it doesn't reset blink negative delays. This function is used only for testing. BUG=509482 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/408db8e06a467aebd58c9b7a0dd0192922fd90b7 Cr-Commit-Position: refs/heads/master@{#341253}

Patch Set 1 #

Patch Set 2 : Add the test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -9 lines) Patch
M cc/animation/layer_animation_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/animation/layer_animation_controller_unittest.cc View 1 2 chunks +37 lines, -8 lines 0 comments Download
M cc/test/animation_test_common.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M cc/test/animation_test_common.cc View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
loyso (OOO)
5 years, 4 months ago (2015-07-28 08:00:44 UTC) #2
ajuma
Please add a unit test for this.
5 years, 4 months ago (2015-07-28 13:04:52 UTC) #3
ajuma
Thanks for the nice test, lgtm.
5 years, 4 months ago (2015-07-30 13:07:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255883006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255883006/20001
5 years, 4 months ago (2015-07-31 00:08:02 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-31 01:08:23 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 01:09:04 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/408db8e06a467aebd58c9b7a0dd0192922fd90b7
Cr-Commit-Position: refs/heads/master@{#341253}

Powered by Google App Engine
This is Rietveld 408576698