LayoutTests/fast/mediarecorder/MediaRecorder-canRecordMimeType-expected.txt - Issue 1255873002: MediaRecorder Blink part

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/mediarecorder/MediaRecorder-canRecordMimeType-expected.txt

Issue 1255873002: MediaRecorder Blink part (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: peter@ comments and nits Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/mediarecorder/MediaRecorder-canRecordMimeType.html ('k') | LayoutTests/webexposed/global-interface-listing-expected.txt » ('j') | Source/modules/mediarecorder/MediaRecorder.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 This is a testharness.js-based test.

	2 PASS check MediaRecorder.canRecordMimeType() with video/invalid

	3 FAIL check MediaRecorder.canRecordMimeType() with video/webm and vp8 assert_equa ls: expected "maybe" but got ""
	Peter Beverloo 2015/09/02 16:39:37 Out of interest, aren't these tests going to fail Out of interest, aren't these tests going to fail when you implement the Chromium-side of this change? If so, you may want to remove them now, and add them after that lands. It saves you from a 3-sided patch, and means that you don't have to check in failing expectations. mcasas 2015/09/02 21:01:47 Yeah, this was a conundrum, I didn't want to land Show quoted text On 2015/09/02 16:39:37, Peter Beverloo wrote: > Out of interest, aren't these tests going to fail when you implement the > Chromium-side of this change? If so, you may want to remove them now, and add > them after that lands. It saves you from a 3-sided patch, and means that you > don't have to check in failing expectations. Yeah, this was a conundrum, I didn't want to land all this code with no hints as to how it was supposed to work, in the form of tests, but then I need to check the FAIL expectations. It'd be great if I could commit a single CL that would "connect" with the Chrome classes and update the ...-expected.txt, ideas?
	4 PASS check MediaRecorder.canRecordMimeType() with audio/invalid

	5 FAIL check MediaRecorder.canRecordMimeType() with audio/webm and opus assert_equ als: expected "maybe" but got ""

	6 Harness: the test ran to completion.

	7

OLD	NEW