Source/platform/exported/WebMediaRecorderHandlerClient.cpp - Issue 1255873002: MediaRecorder Blink part

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/platform/exported/WebMediaRecorderHandlerClient.cpp

Issue 1255873002: MediaRecorder Blink part (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: peter@ comments. Removed BlobEvent, moved MediaRecorder* to Source/modules/mediarecorder Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "config.h"

	6 #include "public/platform/WebMediaRecorderHandlerClient.h"

	7

	8 // This file just includes config.h and WebMediaPlayerClient.h, to make sure

	9 // MSVC compiler does not fail linking with LNK2019 or LNK2001 due to unresolved

	10 // constructor/destructor and should be in Source/platform/exported.
	Peter Beverloo 2015/09/01 17:17:12 The compile logs aren't available anymore (I can't The compile logs aren't available anymore (I can't repo on Linux, but we knew that), but we should be able to get rid of this file. Other features have similar set-ups, and don't need a file like this. Let me comment further in the WebMediaRecorderHandlerClient file. mcasas 2015/09/02 03:10:18 Acknowledged. Show quoted text On 2015/09/01 17:17:12, Peter Beverloo wrote: > The compile logs aren't available anymore (I can't repo on Linux, but we knew > that), but we should be able to get rid of this file. Other features have > similar set-ups, and don't need a file like this. > > Let me comment further in the WebMediaRecorderHandlerClient file. Acknowledged.
OLD	NEW