Source/modules/mediastream/BlobEvent.idl - Issue 1255873002: MediaRecorder Blink part

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/mediastream/BlobEvent.idl

Issue 1255873002: MediaRecorder Blink part (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: esprehn@ comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/mediastream/BlobEvent.cpp ('K') | « Source/modules/mediastream/BlobEvent.cpp ('k') | Source/modules/mediastream/MediaRecorder.h » ('j') | Source/modules/mediastream/MediaRecorderErrorEvent.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://w3c.github.io/mediacapture-record/MediaRecorder.html#blob-event

	6

	7 [

	8 NoInterfaceObject
	Peter Beverloo 2015/08/28 17:18:24 The spec defines this as having a constructor and The spec defines this as having a constructor and having an interface object (which means whether it's exposed on the window global). Perhaps split out the BlobEvent(Init) in a different CL, since that can be landed stand-alone of the rest? mcasas 2015/08/29 01:12:57 Ok, following the suggestions I'll leave BlobEvent Show quoted text On 2015/08/28 17:18:24, Peter Beverloo wrote: > The spec defines this as having a constructor and having an interface object > (which means whether it's exposed on the window global). > > Perhaps split out the BlobEvent(Init) in a different CL, since that can be > landed stand-alone of the rest? Ok, following the suggestions I'll leave BlobEvent out of this CL. In my defense I'd say that I wanted to land chunks at a time and was instructed to try and land full functionalities ;) Peter Beverloo 2015/09/01 17:17:12 I think experience has taught us that small CLs ge Show quoted text On 2015/08/29 01:12:57, mcasas wrote: > On 2015/08/28 17:18:24, Peter Beverloo wrote: > > The spec defines this as having a constructor and having an interface object > > (which means whether it's exposed on the window global). > > > > Perhaps split out the BlobEvent(Init) in a different CL, since that can be > > landed stand-alone of the rest? > > Ok, following the suggestions I'll leave BlobEvent out of this CL. > > In my defense I'd say that I wanted to land chunks at a time and > was instructed to try and land full functionalities ;) I think experience has taught us that small CLs get reviewed much more quickly as it's easier for reviewers to put them between other tasks :-). I certainly prefer them.
	9 ]

	10 interface BlobEvent : Event {

	11 readonly attribute Blob data;

	12 };

OLD	NEW