Source/modules/mediastream/MediaRecorderErrorEvent.idl - Issue 1255873002: MediaRecorder Blink part

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/mediastream/MediaRecorderErrorEvent.idl

Issue 1255873002: MediaRecorder Blink part (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 4 spaces indentation and rebased. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/mediastream/MediaRecorder.idl ('K') | « Source/modules/mediastream/MediaRecorderErrorEvent.cpp ('k') | Source/modules/mediastream/WindowMediaStream.idl » ('j') | public/platform/WebMediaRecorderHandler.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://w3c.github.io/mediacapture-record/MediaRecorder.html#MediaRecorderErr orEvent

	6 // https://w3c.github.io/mediacapture-record/MediaRecorder.html#idl-def-Recordin gErrorNameEnum

	7

	8 enum RecordingErrorNameEnum {

	9 "InvalidState",

	10 "OutOfMemory",

	11 "IllegalStreamModification",

	12 "SecurityError",

	13 "OtherRecordingError"

	14 };

	15

	16 [

	17 NoInterfaceObject

	18 ] interface MediaRecorderErrorEvent : Event {

	19 readonly attribute RecordingErrorNameEnum name;
	esprehn 2015/08/21 08:46:13 Having a name property like this is very weird, I Having a name property like this is very weird, I think you want to just fire a DOMException and reuse the existing types for that. You're recreating that same thing here, we already have InvalidState and SecurityError types. If you need more error types please have them added for the DOMException. mcasas 2015/08/21 18:50:05 Seems like MediaRecordingError raises eyebrows in Show quoted text On 2015/08/21 08:46:13, esprehn wrote: > Having a name property like this is very weird, I think you want to just fire a > DOMException and reuse the existing types for that. You're recreating that same > thing here, we already have InvalidState and SecurityError types. If you need > more error types please have them added for the DOMException. Seems like MediaRecordingError raises eyebrows in everyone reading it :) but I just took it verbatim from the linked W3C draft. Please advise, scrap it and reuse or comply?
	20 readonly attribute DOMString? message;

	21 };

OLD	NEW