LayoutTests/fast/mediarecorder/MediaRecorder-basic-video-expected.txt - Issue 1255873002: MediaRecorder Blink part

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/mediarecorder/MediaRecorder-basic-video-expected.txt

Issue 1255873002: MediaRecorder Blink part (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 4 spaces indentation and rebased. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 This is a testharness.js-based test.

	2 FAIL checks the video-only MediaRecorder API. assert_unreached: Exception while creating MediaRecorder: NotSupportedError: Failed to construct 'MediaRecorder': No MediaRecorder handler can be created. Reached unreachable code
	esprehn 2015/08/21 08:46:12 seems your tests don't work? seems your tests don't work? mcasas 2015/08/21 18:50:04 I might be understanding things the wrong way: Pl Show quoted text On 2015/08/21 08:46:12, esprehn wrote: > seems your tests don't work? I might be understanding things the wrong way: Platform::current()->createMediaRecorderHandler() returns nullptr right now, but that's because there's no Chromium part implemented yet. So this creation would and should fail. When the Cr part is landed, these expectations should be updated. Right? Or should I provide a mock for it, and where?
	3 Harness: the test ran to completion.

	4

OLD	NEW