MediaRecorder Blink part

public/platform/WebMediaRecorderHandler.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef WebMediaRecorderHandler_h
+#define WebMediaRecorderHandler_h
+
+#include "WebCommon.h"
+
+namespace blink {
+
+class WebMediaRecorderHandlerClient;
+class WebMediaStream;
+class WebString;
+
+class BLINK_PLATFORM_EXPORT WebMediaRecorderHandler {

[Peter Beverloo, 2015/07/29 16:54:23]

nit: ++comments please :)

[mcasas, 2015/07/30 13:20:37]

Done.
Classes in public/platform are seldom commented :?

+public:
+    virtual ~WebMediaRecorderHandler() { }
+    virtual bool canSupportMimeType(const WebString& mimeType) = 0;
+    virtual bool initialize(WebMediaRecorderHandlerClient*,
+                            const WebMediaStream&,
+                            const WebString& mimeType) = 0;

[Peter Beverloo, 2015/07/29 16:54:23]

nit: Please do use argument names in the public API.

(Personally I'm fine with *always* using them.)

[mcasas, 2015/07/30 13:20:37]

Done.

+    virtual bool start() = 0;
+    virtual bool start(int timeslice) = 0;
+    virtual void stop() = 0;
+    virtual void pause() = 0;
+    virtual void resume() = 0;
+};
+
+} // namespace blink
+#endif