Source/modules/mediastream/MediaRecorderErrorEvent.idl - Issue 1255873002: MediaRecorder Blink part

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/mediastream/MediaRecorderErrorEvent.idl

Issue 1255873002: MediaRecorder Blink part (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/mediastream/MediaRecorderErrorEvent.h ('K') | « Source/modules/mediastream/MediaRecorderErrorEvent.cpp ('k') | Source/modules/mediastream/WindowMediaStream.idl » ('j') | public/platform/Platform.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // http://w3c.github.io/mediacapture-record/MediaRecorder.html#MediaRecorderErro rEvent

	6 // http://w3c.github.io/mediacapture-record/MediaRecorder.html#idl-def-Recording ErrorNameEnum
	Peter Beverloo 2015/07/29 16:54:22 nit: https nit: https mcasas 2015/07/30 13:20:37 Done. Show quoted text On 2015/07/29 16:54:22, Peter Beverloo wrote: > nit: https Done.
	7

	8 enum RecordingErrorNameEnum {
	Peter Beverloo 2015/07/29 16:54:22 Huh? I find this odd API design. Why doesn't the Huh? I find this odd API design. Why doesn't the specification drop all of 6.2-6.4 and use actual DOMExceptions instead? (I realize that you may not have the answer.) mcasas 2015/07/30 13:20:37 I don't know, the W3C spec is a bit old so it's no Show quoted text On 2015/07/29 16:54:22, Peter Beverloo wrote: > Huh? I find this odd API design. > > Why doesn't the specification drop all of 6.2-6.4 and use actual DOMExceptions > instead? (I realize that you may not have the answer.) I don't know, the W3C spec is a bit old so it's not impossible that is outdated. Then again, this MediaRecorderErrorEvent was added after the original Draft was written. Should I add a TODO() and ping the W3C, or any other suggestions...?
	9 "InvalidState",

	10 "OutOfMemory",

	11 "IllegalStreamModification",

	12 "SecurityError",

	13 "OtherRecordingError"

	14 };

	15

	16 [

	17 NoInterfaceObject

	18 ] interface MediaRecorderErrorEvent : Event {

	19 readonly attribute RecordingErrorNameEnum name;

	20 readonly attribute DOMString? message;
	Peter Beverloo 2015/07/29 16:54:22 nit: four space indent. nit: four space indent. mcasas 2015/07/30 13:20:37 Done. Show quoted text On 2015/07/29 16:54:22, Peter Beverloo wrote: > nit: four space indent. Done.
	21 };

OLD	NEW