MediaRecorder Blink part

Source/modules/mediastream/MediaRecorder.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MediaRecorder_h
+#define MediaRecorder_h
+
+#include "core/dom/ActiveDOMObject.h"
+#include "core/events/EventTarget.h"
+#include "modules/EventTargetModules.h"
+#include "modules/mediastream/MediaStream.h"
+#include "modules/ModulesExport.h"
+#include "platform/AsyncMethodRunner.h"
+#include "public/platform/WebMediaRecorderHandler.h"
+#include "public/platform/WebMediaRecorderHandlerClient.h"
+
+namespace blink {
+
+class BlobData;
+class ExceptionState;
+
+class MODULES_EXPORT MediaRecorder final
+    : public RefCountedGarbageCollectedEventTargetWithInlineData<MediaRecorder>
+    , public WebMediaRecorderHandlerClient
+    , public ActiveDOMObject {
+    REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(MediaRecorder);
+    WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MediaRecorder);
+    DEFINE_WRAPPERTYPEINFO();
+public:
+    static MediaRecorder* create(ExecutionContext*, MediaStream*, ExceptionState&);
+    static MediaRecorder* create(ExecutionContext*, MediaStream*, const String&, ExceptionState&);

[Peter Beverloo, 2015/07/29 16:54:22]

What is "const String&"? We do use argument names in Blink if the meaning can't
be read from the type.

[mcasas, 2015/07/30 13:20:36]

Done.

+
+    virtual ~MediaRecorder();
+
+    MediaStream* stream() const { return m_stream.get(); }
+    String mimeType() const { return m_mimeType; }
+    String state() const { return m_state; }
+
+    DEFINE_ATTRIBUTE_EVENT_LISTENER(start);
+    DEFINE_ATTRIBUTE_EVENT_LISTENER(stop);
+    DEFINE_ATTRIBUTE_EVENT_LISTENER(dataavailable);
+    DEFINE_ATTRIBUTE_EVENT_LISTENER(pause);
+    DEFINE_ATTRIBUTE_EVENT_LISTENER(resume);
+    DEFINE_ATTRIBUTE_EVENT_LISTENER(error);
+
+    bool ignoreMutedMedia() const { return m_ignoreMutedMedia; }
+    void setIgnoreMutedMedia(bool ignoreMutedMedia) { m_ignoreMutedMedia = ignoreMutedMedia; }
+
+    void start(ExceptionState&);
+    void start(int&, ExceptionState&);

[Peter Beverloo, 2015/07/29 16:54:22]

dito re: argument meaning, for int&

[mcasas, 2015/07/30 13:20:36]

Done.

+    void stop(ExceptionState&);
+    void pause(ExceptionState&);
+    void resume(ExceptionState&);
+    void requestData(ExceptionState&);
+
+    static String canRecordMimeType(const String&);

[Peter Beverloo, 2015/07/29 16:54:22]

dito re: argument meaning, for String&

[mcasas, 2015/07/30 13:20:36]

Done.

+
+    // EventTarget
+    virtual const AtomicString& interfaceName() const override;
+    virtual ExecutionContext* executionContext() const override;
+
+    // ActiveDOMObject
+    virtual void suspend() override;
+    virtual void resume() override;
+    virtual void stop() override;
+    virtual bool hasPendingActivity() const override { return !m_stopped; }
+
+    // WebMediaRecorderHandlerClient
+    virtual void writeData(const char* data, size_t length, bool lastInSlice) override;
+    virtual void failOutOfMemory(const WebString& message) override;
+    virtual void failIllegalStreamModification(const WebString& message) override;
+    virtual void failOtherRecordingError(const WebString& message) override;
+
+    DECLARE_VIRTUAL_TRACE();
+
+private:
+    MediaRecorder(ExecutionContext*, MediaStream*, const String&, ExceptionState&);
+
+    void createBlobEvent(PassOwnPtr<BlobData> blobData);
+
+    void doStop();
+    void scheduleDispatchEvent(PassRefPtrWillBeRawPtr<Event>);
+    void dispatchScheduledEvent();
+
+    Member<MediaStream> m_stream;
+    bool m_stopped;
+    String m_mimeType;
+    String m_state;

[Peter Beverloo, 2015/07/29 16:54:22]

I'm not a huge fan of using a String to maintain the state (even AtomicString).
Why not use an enum instead, and have some stateToString() method when the
textual representation is necessary?

[mcasas, 2015/07/30 13:20:36]

Done.

I noticed that there's a textual String representation of
the State in MediaRecorder.idl and another, otherwise
unrelated, in MediaRecorder.cpp. Do you know any way
to link them both?

+    bool m_ignoreMutedMedia;
+
+    OwnPtr<WebMediaRecorderHandler> m_recorderHandler;
+
+    AsyncMethodRunner<MediaRecorder> m_dispatchScheduledEventRunner;
+    WillBeHeapVector<RefPtrWillBeMember<Event>> m_scheduledEvents;
+};
+
+} // namespace blink
+
+#endif // MediaRecorder_h