Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 1255843003: Initialize ResourceRequest::m_requestorOrigin. (Closed)

Created:
5 years, 4 months ago by Mike West
Modified:
5 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Initialize ResourceRequest::m_requestorOrigin. We're not using this on the Chromium side yet, which is good, because as soon as we start converting the exposed 'nullptr' WebSecurityOrigin into a url::Origin, it'll crash. :) This patch fixes that. BUG=459154 Committed: https://crrev.com/315c7d7faa807c2dd6b6ddf515dd84c30a44d816 git-svn-id: svn://svn.chromium.org/blink/trunk@199514 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : Test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M Source/platform/network/ResourceRequest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/network/ResourceRequestTest.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mike West
Hey Jochen. WDYT?
5 years, 4 months ago (2015-07-27 12:55:38 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 4 months ago (2015-07-27 13:07:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255843003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255843003/20001
5 years, 4 months ago (2015-07-27 13:14:47 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=199514
5 years, 4 months ago (2015-07-27 14:21:51 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:48:42 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/315c7d7faa807c2dd6b6ddf515dd84c30a44d816

Powered by Google App Engine
This is Rietveld 408576698