Issue 1255843002: use_x11 is better than is_linux for xdisplaycheck dep in mandoline gn build

Issue 1255843002: use_x11 is better than is_linux for xdisplaycheck dep in mandoline gn build (Closed)

Created:
5 years, 5 months ago by Mostyn Bramley-Moore

Modified:
5 years, 5 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

use_x11 is better than is_linux for xdisplaycheck dep in mandoline gn build Committed: https://crrev.com/91c0df87e4b98d215ffad5f9ac9c66b9a1db31bf Cr-Commit-Position: refs/heads/master@{#340340}

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	mandoline/BUILD.gn	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Mostyn Bramley-Moore

@erg: please take a look at this tiny gn fixup.

5 years, 5 months ago (2015-07-24 08:48:03 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255843002/1

5 years, 5 months ago (2015-07-24 20:58:34 UTC) #6

commit-bot: I haz the power

5 years, 5 months ago (2015-07-24 21:42:04 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/91c0df87e4b98d215ffad5f9ac9c66b9a1db31bf
Cr-Commit-Position: refs/heads/master@{#340340}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages