Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 1255813005: Reduce DefaultConcurrentLinks from phys/4GB to phys/5GB. (Closed)

Created:
5 years, 4 months ago by brucedawson
Modified:
5 years, 4 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Reduce DefaultConcurrentLinks from phys/4GB to phys/5GB. VS 2015 uses about 20% more memory when linking. This caused a severe page-fault storm on my development machine and subsequent tests showed that linking could use ~63 GB of RAM (15 parallel links on a 64 GB machine). This suggests that VS 2013 would also be using a lot of RAM (52.5 GB?) such that very little was left for other applications or disk cache. Linker working sets vary wildly but for some they can be very high: unit_tests.exe hits peak working sets of 7.8 GB/9.5 GB on VS 2013/2015. This change reduces parallel links by 20% (increase RAM-per-linker by 25%). The value can be overridden by setting GYP_LINK_CONCURRENCY. BUG=440500 R=thakis@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/6ee91ad8659871916f9aa840d42e1513befdf638

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M pylib/gyp/generator/ninja.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
brucedawson
What do you think of doing this? I could run some tests to see if ...
5 years, 4 months ago (2015-07-28 00:02:42 UTC) #1
brucedawson
I ran some overnight tests with varying levels of GYP_LINK_CONCURRENCY. In all cases I built ...
5 years, 4 months ago (2015-07-28 17:43:44 UTC) #2
Nico
lgtm
5 years, 4 months ago (2015-07-28 17:46:34 UTC) #3
Nico
Committed patchset #1 (id:1) manually as 6ee91ad8659871916f9aa840d42e1513befdf638 (presubmit successful).
5 years, 4 months ago (2015-07-28 18:19:40 UTC) #4
Nico
5 years, 4 months ago (2015-07-28 18:20:07 UTC) #5
Message was sent while issue was closed.
Right, I think gyp has a separate committers list, sorry. I landed this for you.

Powered by Google App Engine
This is Rietveld 408576698