cc/test/layer_tree_pixel_test.cc - Issue 12558003: cc: Made image comparison for pixel tests error tolerant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/test/layer_tree_pixel_test.cc

Issue 12558003: cc: Made image comparison for pixel tests error tolerant. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added output of error pixel details. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/test/layer_tree_pixel_test.cc

diff --git a/cc/test/layer_tree_pixel_test.cc b/cc/test/layer_tree_pixel_test.cc

index 5235426ae27685206b96f7a32cccd31d7af23406..86e3f30dd69acc247fa4a614a456187ed5b8a4f2 100644

--- a/cc/test/layer_tree_pixel_test.cc

+++ b/cc/test/layer_tree_pixel_test.cc

@@ -66,7 +66,8 @@ void LayerTreePixelTest::SwapBuffersOnThread(LayerTreeHostImpl* host_impl,

// To rebaseline:

// EXPECT_TRUE(WritePNGFile(bitmap, test_data_dir.Append(ref_file_)));

- EXPECT_TRUE(IsSameAsPNGFile(bitmap, test_data_dir.Append(ref_file_), true));

+ EXPECT_TRUE(MatchesPNGFile(bitmap, test_data_dir.Append(ref_file_),

+ ExactPixelComparator(true)));

EndTest();

}

« no previous file with comments | « cc/output/gl_renderer_pixeltest.cc ('k') | cc/test/pixel_comparator.h » ('j') | no next file with comments »