Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: src/debug.h

Issue 1255793003: Debugger: do not hold onto debug infos weakly. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase and address comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/debug.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug.h
diff --git a/src/debug.h b/src/debug.h
index 25c3ebcf01ff390abbb92d1c20171335bc8e442f..49554f7ab889130da5ffa454695f693f5e06071e 100644
--- a/src/debug.h
+++ b/src/debug.h
@@ -214,14 +214,12 @@ class ScriptCache {
class DebugInfoListNode {
public:
explicit DebugInfoListNode(DebugInfo* debug_info);
- virtual ~DebugInfoListNode() { ClearInfo(); }
+ ~DebugInfoListNode();
DebugInfoListNode* next() { return next_; }
void set_next(DebugInfoListNode* next) { next_ = next; }
Handle<DebugInfo> debug_info() { return Handle<DebugInfo>(debug_info_); }
- void ClearInfo();
-
private:
// Global (weak) handle to the debug info object.
DebugInfo** debug_info_;
@@ -476,10 +474,6 @@ class Debug {
LiveEdit::FrameDropMode mode,
Object** restarter_frame_function_pointer);
- // Passed to MakeWeak.
- static void HandlePhantomDebugInfo(
- const PhantomCallbackData<DebugInfoListNode>& data);
-
// Threading support.
char* ArchiveDebug(char* to);
char* RestoreDebug(char* from);
@@ -600,9 +594,6 @@ class Debug {
void ActivateStepOut(StackFrame* frame);
void ClearStepNext();
void RemoveDebugInfoAndClearFromShared(Handle<DebugInfo> debug_info);
- void RemoveDebugInfo(DebugInfo** debug_info);
- void RemoveDebugInfo(DebugInfoListNode* node);
- void RemoveDebugInfo(DebugInfoListNode* prev, DebugInfoListNode* node);
Handle<Object> CheckBreakPoints(Handle<Object> break_point);
bool CheckBreakPoint(Handle<Object> break_point_object);
« no previous file with comments | « no previous file | src/debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698