Debugger: do not hold onto debug infos weakly.

src/debug.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_DEBUG_H_
 #define V8_DEBUG_H_
 
 #include "src/allocation.h"
 #include "src/arguments.h"
 #include "src/assembler.h"
@@ skipping 196 matching lines @@
   Isolate* isolate_;
   Handle<WeakValueHashTable> table_;
 };
 
 
 // Linked list holding debug info objects. The debug info objects are kept as
 // weak handles to avoid a debug info object to keep a function alive.
 class DebugInfoListNode {
  public:
   explicit DebugInfoListNode(DebugInfo* debug_info);
-  virtual ~DebugInfoListNode() { ClearInfo(); }
+  ~DebugInfoListNode();
 
   DebugInfoListNode* next() { return next_; }
   void set_next(DebugInfoListNode* next) { next_ = next; }
   Handle<DebugInfo> debug_info() { return Handle<DebugInfo>(debug_info_); }
 
-  void ClearInfo();
-
  private:
   // Global (weak) handle to the debug info object.
   DebugInfo** debug_info_;
 
   // Next pointer for linked list.
   DebugInfoListNode* next_;
 };
 
 
 
@@ skipping 234 matching lines @@
   bool IsDebugGlobal(GlobalObject* global);
 
   // Check whether this frame is just about to return.
   bool IsBreakAtReturn(JavaScriptFrame* frame);
 
   // Support for LiveEdit
   void FramesHaveBeenDropped(StackFrame::Id new_break_frame_id,
                              LiveEdit::FrameDropMode mode,
                              Object** restarter_frame_function_pointer);
 
-  // Passed to MakeWeak.
-  static void HandlePhantomDebugInfo(
-      const PhantomCallbackData<DebugInfoListNode>& data);
-
   // Threading support.
   char* ArchiveDebug(char* to);
   char* RestoreDebug(char* from);
   static int ArchiveSpacePerThread();
   void FreeThreadResources() { }
 
   // Record function from which eval was called.
   static void RecordEvalCaller(Handle<Script> script);
 
   bool CheckExecutionState(int id) {
@@ skipping 100 matching lines @@
                             bool auto_continue);
   void InvokeMessageHandler(MessageImpl message);
 
   static bool CompileDebuggerScript(Isolate* isolate, int index);
   void ClearOneShot();
   void ActivateStepIn(StackFrame* frame);
   void ClearStepIn();
   void ActivateStepOut(StackFrame* frame);
   void ClearStepNext();
   void RemoveDebugInfoAndClearFromShared(Handle<DebugInfo> debug_info);
-  void RemoveDebugInfo(DebugInfo** debug_info);
-  void RemoveDebugInfo(DebugInfoListNode* node);
-  void RemoveDebugInfo(DebugInfoListNode* prev, DebugInfoListNode* node);
   Handle<Object> CheckBreakPoints(Handle<Object> break_point);
   bool CheckBreakPoint(Handle<Object> break_point_object);
 
   inline void AssertDebugContext() {
     DCHECK(isolate_->context() == *debug_context());
     DCHECK(in_debug_scope());
   }
 
   void ThreadInit();
 
@@ skipping 179 matching lines @@
                            int call_argc = -1);
 
   static void PatchDebugBreakSlot(Address pc, Handle<Code> code);
   static void ClearDebugBreakSlot(Address pc);
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_DEBUG_H_