Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8002)

Unified Diff: chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.h

Issue 1255783002: [Mac] Factor out keyboard shortcut handling from ChromeEventProcessingWindow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@execute
Patch Set: Separate CommandDispatcher and CommandDispatcherDelegate. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.h
diff --git a/chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.h b/chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.h
new file mode 100644
index 0000000000000000000000000000000000000000..40529dcce277e4bb9bd75a72864714b41c5a58e7
--- /dev/null
+++ b/chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.h
@@ -0,0 +1,23 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_COCOA_CHROME_COMMAND_DISPATCHER_DELEGATE_H_
+#define CHROME_BROWSER_UI_COCOA_CHROME_COMMAND_DISPATCHER_DELEGATE_H_
+
+#import <Cocoa/Cocoa.h>
+
+#import "ui/base/cocoa/command_dispatcher.h"
+
+// Implement CommandDispatcherDelegate by intercepting browser window keyboard
+// shortcuts and executing them with chrome::ExecuteCommand.
+@interface ChromeCommandDispatcherDelegate : NSObject<CommandDispatcherDelegate>
+
+// Checks if |event| is a window, delayed window, or browser keyboard shortcut.
+// (See global_keyboard_shortcuts_mac.h for details). If so, execute the
+// associated command. Returns YES if the event was handled.
+- (BOOL)handleExtraKeyboardShortcut:(NSEvent*)event window:(NSWindow*)window;
tapted 2015/08/18 07:22:12 Can this stay in ChromeEventProcessingWindow?
jackhou1 2015/08/25 06:31:12 It could, but then we'd need to expose Handle*Keyb
+
+@end
+
+#endif // CHROME_BROWSER_UI_COCOA_CHROME_COMMAND_DISPATCHER_DELEGATE_H_

Powered by Google App Engine
This is Rietveld 408576698