chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.h - Issue 1255783002: [Mac] Factor out keyboard shortcut handling from ChromeEventProcessingWindow.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.h

Issue 1255783002: [Mac] Factor out keyboard shortcut handling from ChromeEventProcessingWindow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@execute

Patch Set: Address comments. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_COCOA_CHROME_COMMAND_DISPATCHER_DELEGATE_H_

	6 #define CHROME_BROWSER_UI_COCOA_CHROME_COMMAND_DISPATCHER_DELEGATE_H_

	7

	8 #import <Cocoa/Cocoa.h>

	9

	10 #import "ui/base/cocoa/command_dispatcher.h"

	11

	12 // Implement CommandDispatcherDelegate by intercepting browser window keyboard

	13 // shortcuts and executing them with chrome::ExecuteCommand.

	14 @interface ChromeCommandDispatcherDelegate : NSObject<CommandDispatcherDelegate>

	15

	16 // Checks if \|event\| is a window, delayed window, or browser keyboard shortcut.
	Robert Sesek 2015/08/26 17:46:49 This reads like the window is delayed rather than This reads like the window is delayed rather than the event. jackhou1 2015/08/27 00:01:25 Done. Show quoted text On 2015/08/26 17:46:49, Robert Sesek wrote: > This reads like the window is delayed rather than the event. Done.
	17 // (See global_keyboard_shortcuts_mac.h for details). If so, execute the

	18 // associated command. Returns YES if the event was handled.

	19 - (BOOL)handleExtraKeyboardShortcut:(NSEvent)event window:(NSWindow)window;

	20

	21 @end

	22

	23 #endif // CHROME_BROWSER_UI_COCOA_CHROME_COMMAND_DISPATCHER_DELEGATE_H_

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.mm » ('j') | ui/base/cocoa/command_dispatcher.h » ('J')