[Mac] Factor out keyboard shortcut handling from ChromeEventProcessingWindow.

ui/views/controls/webview/webview.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/webview/webview.h"
 
 #include "content/public/browser/browser_accessibility_state.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
 #include "ipc/ipc_message.h"
 #include "ui/accessibility/ax_enums.h"
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/events/event.h"
 #include "ui/views/controls/native/native_view_host.h"
 #include "ui/views/focus/focus_manager.h"
 #include "ui/views/views_delegate.h"
+#include "ui/views/widget/native_widget_private.h"
 
 namespace views {
 
 // static
 const char WebView::kViewClassName[] = "WebView";
 
 ////////////////////////////////////////////////////////////////////////////////
 // WebView, public:
 
 WebView::WebView(content::BrowserContext* browser_context)
@@ skipping 211 matching lines @@
 
 void WebView::RenderProcessHostDestroyed(content::RenderProcessHost* host) {
   DCHECK_EQ(host, observing_render_process_host_);
   observing_render_process_host_->RemoveObserver(this);
   observing_render_process_host_ = nullptr;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // WebView, content::WebContentsDelegate implementation:
 
+void WebView::HandleKeyboardEvent(

[tapted, 2015/08/18 07:22:13]

is this override only to support views_examples? (if so, we might want to
separate that out to a different CL - I think in practice  it's more common for
webviews to be used like 

WebContents* web_contents = foo();
webview->SetWebContents(web_contents);

and in this case the WebView isn't the delegate for the WebContents, so this
won't get called.

An alternative fix for ViewsExamples might be to make WebViewExample the
WebContentsDelegate, and make use of UnhandledKeyboardEventHandler (i.e. same as
NativeAppWindowViews and friends). Of course we'd need to implement
UnhandledKeyboardEventHandler::HandleNativeKeyboardEvent like you were before
(and we may still need RepostNativeEvent to be implmeneted as well, but it looks
like WebDialog is the only caller and AFAIK it's not used much outside of
ChromeOS.... if at all even: InlineLoginDialog looks like dead code outside
ChromeOS).

[jackhou1, 2015/08/25 06:31:12]

Done.

Left it in this CL because it's a fairly small change, let me know if you prefer
to have it split out.

+    content::WebContents* source,
+    const content::NativeWebKeyboardEvent& event) {
+  if (!event.os_event)
+    return;
+
+  GetWidget()->native_widget_private()->RepostNativeEvent(event.os_event);
+}
+
 bool WebView::EmbedsFullscreenWidget() const {
   DCHECK(wc_owner_.get());
   return embed_fullscreen_widget_mode_enabled_;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // WebView, content::WebContentsObserver implementation:
 
 void WebView::RenderViewReady() {
   NotifyMaybeTextInputClientAndAccessibilityChanged();
@@ skipping 130 matching lines @@
   if (!contents) {
     content::WebContents::CreateParams create_params(
         browser_context, NULL);
     return content::WebContents::Create(create_params);
   }
 
   return contents;
 }
 
 }  // namespace views