Issue 125573002: Move ExtensionService::GetExtensionById() to ExtensionRegistry

Issue 125573002: Move ExtensionService::GetExtensionById() to ExtensionRegistry (Closed)

Created:
6 years, 11 months ago by James Cook

Modified:
6 years, 11 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, jeremya+watch_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move ExtensionService::GetExtensionById() to ExtensionRegistry This will allow app_shell to use it without an ExtensionService BUG=none TEST=added unit_tests ExtensionRegistryTest.GetExtensionById R=yoz@chromium.org TBR=pkotwicz@chromium.org for chrome/browser/themes Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243423

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase, add test, get_extension_by_id #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+179 lines, -83 lines)			Patch
M	chrome/browser/extensions/extension_service.h	View	1	2 chunks	+7 lines, -17 lines	0 comments	Download
M	chrome/browser/extensions/extension_service.cc	View	1	7 chunks	+19 lines, -43 lines	0 comments	Download
M	chrome/browser/extensions/extension_util.cc	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/themes/theme_service_unittest.cc	View	1	7 chunks	+19 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/extensions/application_launch.cc	View	1	3 chunks	+7 lines, -9 lines	0 comments	Download
M	extensions/browser/extension_registry.h	View	1	2 chunks	+19 lines, -0 lines	0 comments	Download
M	extensions/browser/extension_registry.cc	View	1	2 chunks	+27 lines, -0 lines	0 comments	Download
M	extensions/browser/extension_registry_unittest.cc	View	1	1 chunk	+75 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yoyo Zhou

LGTM https://chromiumcodereview.appspot.com/125573002/diff/1/extensions/browser/extension_registry_unittest.cc File extensions/browser/extension_registry_unittest.cc (right): https://chromiumcodereview.appspot.com/125573002/diff/1/extensions/browser/extension_registry_unittest.cc#newcode101 extensions/browser/extension_registry_unittest.cc:101: TEST_F(ExtensionRegistryTest, GetExtensionById) { Add at least one test ...

6 years, 11 months ago (2014-01-07 02:26:12 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/125573002/80001

6 years, 11 months ago (2014-01-07 18:10:07 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242690

6 years, 11 months ago (2014-01-07 22:31:19 UTC) #4

James Cook

6 years, 11 months ago (2014-01-07 23:06:07 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r243423 (presubmit successful).

Expand Messages | Collapse Messages