Revert "FX_BOOL considered harmful, part 2."

core/include/fxcrt/fx_string.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef CORE_INCLUDE_FXCRT_FX_STRING_H_
 #define CORE_INCLUDE_FXCRT_FX_STRING_H_
 
 #include <stdint.h>  // For intptr_t.
@@ skipping 652 matching lines @@
 
     // Implicit conversion to C-style wide string -- deprecated
     operator const FX_WCHAR*() const
     {
         return m_pData ? m_pData->m_String : L"";
     }
 
     void                                        Empty();
 
 
-    bool                                        IsEmpty() const
+    FX_BOOL                                     IsEmpty() const
     {
         return !GetLength();
     }
 
     FX_STRSIZE                          GetLength() const
     {
         return m_pData ? m_pData->m_nDataLength : 0;
     }
 
     const CFX_WideString&       operator = (const FX_WCHAR* str);
@@ skipping 204 matching lines @@
 inline bool operator== (const CFX_WideStringC& lhs, const CFX_WideString& rhs) {
     return rhs == lhs;
 }
 inline bool operator!= (const wchar_t* lhs, const CFX_WideString& rhs) {
     return rhs != lhs;
 }
 inline bool operator!= (const CFX_WideStringC& lhs, const CFX_WideString& rhs) {
     return rhs != lhs;
 }
 FX_FLOAT FX_atof(const CFX_ByteStringC& str);
-void FX_atonum(const CFX_ByteStringC& str, bool& bInteger, void* pData);
+void FX_atonum(const CFX_ByteStringC& str, FX_BOOL& bInteger, void* pData);
 FX_STRSIZE FX_ftoa(FX_FLOAT f, FX_CHAR* buf);
 CFX_ByteString  FX_UTF8Encode(const FX_WCHAR* pwsStr, FX_STRSIZE len);
 inline CFX_ByteString   FX_UTF8Encode(const CFX_WideStringC& wsStr)
 {
     return FX_UTF8Encode(wsStr.GetPtr(), wsStr.GetLength());
 }
 inline CFX_ByteString   FX_UTF8Encode(const CFX_WideString &wsStr)
 {
     return FX_UTF8Encode(wsStr.c_str(), wsStr.GetLength());
 }
 
 #endif  // CORE_INCLUDE_FXCRT_FX_STRING_H_