Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1255673004: Proof-reading comments in base/message_loop/. (Closed)

Created:
5 years, 5 months ago by qyearsley
Modified:
5 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Proof-reading comments in base/message_loop/. This CL contains a few minor changes to comments that I made while skimming through the code. Mostly spelling changes. Committed: https://crrev.com/15926f8886b8fa20c044c02eb0387f44e611c993 Cr-Commit-Position: refs/heads/master@{#340383}

Patch Set 1 #

Total comments: 2

Patch Set 2 : imcoming -> incoming #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M base/message_loop/incoming_task_queue.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_loop.h View 3 chunks +7 lines, -7 lines 0 comments Download
M base/message_loop/message_loop.cc View 1 6 chunks +7 lines, -7 lines 0 comments Download
M base/message_loop/message_loop_task_runner_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/message_loop/message_loop_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M base/message_loop/message_pump_glib.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/message_loop/message_pump_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_pump_win.h View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_pump_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
qyearsley
5 years, 5 months ago (2015-07-24 00:15:47 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1255673004/diff/1/base/message_loop/message_loop.cc File base/message_loop/message_loop.cc (right): https://codereview.chromium.org/1255673004/diff/1/base/message_loop/message_loop.cc#newcode365 base/message_loop/message_loop.cc:365: // We only check the imcoming queue, since ...
5 years, 5 months ago (2015-07-24 01:39:51 UTC) #3
qyearsley
https://codereview.chromium.org/1255673004/diff/1/base/message_loop/message_loop.cc File base/message_loop/message_loop.cc (right): https://codereview.chromium.org/1255673004/diff/1/base/message_loop/message_loop.cc#newcode365 base/message_loop/message_loop.cc:365: // We only check the imcoming queue, since we ...
5 years, 5 months ago (2015-07-24 02:18:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255673004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255673004/20001
5 years, 5 months ago (2015-07-24 03:56:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/95285) android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 5 months ago (2015-07-24 04:06:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255673004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255673004/20001
5 years, 5 months ago (2015-07-24 23:13:48 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-25 00:33:51 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-25 00:34:41 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/15926f8886b8fa20c044c02eb0387f44e611c993
Cr-Commit-Position: refs/heads/master@{#340383}

Powered by Google App Engine
This is Rietveld 408576698