Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1255613002: Reduce duplicate code in full-codegen across platforms. (Closed)

Created:
5 years, 5 months ago by Yang
Modified:
5 years, 5 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reduce duplicate code in full-codegen across platforms. R=mvstanton@chromium.org Committed: https://crrev.com/937d4efbf9c399339fdc8e041bec8e80baa7b58f Cr-Commit-Position: refs/heads/master@{#29798} Committed: https://crrev.com/0fe2fbd173c5e547e021476428001cac6fcdf7a9 Cr-Commit-Position: refs/heads/master@{#29805}

Patch Set 1 #

Patch Set 2 : fix mips #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -880 lines) Patch
M src/arm/full-codegen-arm.cc View 1 8 chunks +0 lines, -111 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 8 chunks +0 lines, -110 lines 0 comments Download
M src/full-codegen.cc View 1 4 chunks +111 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 8 chunks +0 lines, -111 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 8 chunks +0 lines, -110 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 8 chunks +0 lines, -110 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 8 chunks +0 lines, -109 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 8 chunks +0 lines, -109 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 8 chunks +0 lines, -110 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Yang
5 years, 5 months ago (2015-07-23 07:32:26 UTC) #1
mvstanton
lgtm
5 years, 5 months ago (2015-07-23 07:33:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255613002/1
5 years, 5 months ago (2015-07-23 07:40:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-23 08:23:21 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/937d4efbf9c399339fdc8e041bec8e80baa7b58f Cr-Commit-Position: refs/heads/master@{#29798}
5 years, 5 months ago (2015-07-23 08:23:41 UTC) #6
Yang
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1252513004/ by yangguo@chromium.org. ...
5 years, 5 months ago (2015-07-23 09:49:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255613002/20001
5 years, 5 months ago (2015-07-23 11:19:04 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-23 11:46:03 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 11:46:16 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0fe2fbd173c5e547e021476428001cac6fcdf7a9
Cr-Commit-Position: refs/heads/master@{#29805}

Powered by Google App Engine
This is Rietveld 408576698