Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1255583002: Move AppMenuTest from ChromeShellTest to ChromePublicTest (Closed)

Created:
5 years, 5 months ago by pkotwicz
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move AppMenuTest from ChromeShellTest to ChromePublicTest BUG=505040 TEST=None TBR=aurimas Committed: https://crrev.com/d726c606917c0a93d63411c0d118040d6ddded4c Cr-Commit-Position: refs/heads/master@{#340131}

Patch Set 1 : #

Patch Set 2 : #

Messages

Total messages: 15 (6 generated)
pkotwicz
aurimas@ can you please take a look?
5 years, 5 months ago (2015-07-23 16:36:30 UTC) #2
aurimas (slooooooooow)
Can we combine MenuTest.java and AppMenuTest.java?
5 years, 5 months ago (2015-07-23 16:38:31 UTC) #4
pkotwicz
aurimas@ can you please take another look? I have combined MenuTest.java and AppMenuTest.java
5 years, 5 months ago (2015-07-23 17:38:54 UTC) #6
aurimas (slooooooooow)
lgtm
5 years, 5 months ago (2015-07-23 17:47:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255583002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255583002/60001
5 years, 5 months ago (2015-07-23 18:15:38 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/81469)
5 years, 5 months ago (2015-07-23 18:35:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255583002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255583002/60001
5 years, 5 months ago (2015-07-23 18:46:11 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 5 months ago (2015-07-23 19:06:22 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 19:07:53 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d726c606917c0a93d63411c0d118040d6ddded4c
Cr-Commit-Position: refs/heads/master@{#340131}

Powered by Google App Engine
This is Rietveld 408576698