Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: content/browser/frame_host/navigation_entry_impl.cc

Issue 1255573005: Create FrameNavigationEntries for the initial blank page in subframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests and move has_committed_real_load Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_entry_impl.cc
diff --git a/content/browser/frame_host/navigation_entry_impl.cc b/content/browser/frame_host/navigation_entry_impl.cc
index 904a9bf080f35625e24d2e2ea1fce88f89b2fd29..27624d599bc88d6e12b86c9a747d8e7f3764c464 100644
--- a/content/browser/frame_host/navigation_entry_impl.cc
+++ b/content/browser/frame_host/navigation_entry_impl.cc
@@ -545,7 +545,7 @@ void NavigationEntryImpl::AddOrUpdateFrameEntry(FrameTreeNode* frame_tree_node,
// still the initial about:blank page, and we don't currently keep a
// FrameNavigationEntry for that. We ignore such commits, similar to how we
// handle them at the top level.
- // TODO(creis): Consider creating FNEs for initial about:blank commits.
+ NOTREACHED() << "Shouldn't see a commit for a subframe before parent.";
Charlie Reis 2015/07/23 19:57:34 This reverts https://crrev.com/334385. (I can put
Avi (use Gerrit) 2015/07/23 20:27:58 Acknowledged.
Charlie Reis 2015/07/23 22:02:22 Done.
return;
}
@@ -561,11 +561,9 @@ void NavigationEntryImpl::AddOrUpdateFrameEntry(FrameTreeNode* frame_tree_node,
}
}
- // No entry exists yet, so create a new one unless it's for about:blank.
+ // No entry exists yet, so create a new one.
// Unordered list, since we expect to look up entries by frame sequence number
// or unique name.
- if (url == GURL(url::kAboutBlankURL))
- return;
FrameNavigationEntry* frame_entry = new FrameNavigationEntry(
frame_tree_node_id, item_sequence_number, document_sequence_number,
site_instance, url, referrer);

Powered by Google App Engine
This is Rietveld 408576698